Login with current user in GraphiQL #35
Conversation
|
@lorensr now that apollographql/apollo-server#133 is merged, we can merge this code |
| @@ -28,7 +30,9 @@ const defaultOptions = { | |||
|
|
|||
| export const createApolloServer = (givenOptions, givenConfig) => { | |||
|
|
|||
| let graphiqlOptions = Object.assign({}, defaultConfig.graphiqlOptions, givenConfig.graphiqlOptions); | |||
| let config = Object.assign({}, defaultConfig, givenConfig); | |||
There was a problem hiding this comment.
I think this line should take care of all attributes, including graphiqlOptions?
There was a problem hiding this comment.
If we do it that way any graphiqlOptions that we pass will override the whole defaultConfig.graphiqlOptions object. That's because Object.assign is not deep.
|
Let me know when your addition is published in a new version of |
|
@lorensr I think we'll publish 0.3 in a few days. it will include this change and a few others. |
|
Awesome @nicolaslopezj! 🎉 |
|
@lorensr I think this is ready to go? |
|
Working!
|
|
Thanks Nicolas, included in v0.1.2! 🙌😄 https://github.com/apollostack/meteor-integration/blob/master/CHANGELOG.md#012---2016-10-04 |
|
confirmed working for me too 👍 |
Provides the Meteor authorization header automatically.
This works with apollographql/apollo-server#133
This fixes #29